Skip to content

fix: set default TTL for APCu cache as per docs #46395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icewind1991 merged 5 commits into from
Aug 7, 2024
Merged

fix: set default TTL for APCu cache as per docs #46395

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd9cc01
fix: set default TTL for APCu cache as per docs
icewind1991 Jul 10, 2024
4691d19
docs: clearify IMemcache::inc and dec behavior
icewind1991 Jul 10, 2024
b19652a
chore: cleanup acpu inc and dec
icewind1991 Jul 10, 2024
cae0a82
chore: remove Redis::DEFAULT_TTL constant now that it's defined in th…
icewind1991 Jul 10, 2024
5490b12
chore: add psalm false positive to psalm.xml
icewind1991 Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: set default TTL for APCu cache as per docs 
Signed-off-by: Robin Appelman <robin@icewind.nl>
  • Loading branch information
@icewind1991
icewind1991 committed Aug 7, 2024
commit cd9cc01b7739535cc9246103f90ae2d02d8ea217
6 changes: 6 additions & 0 deletions lib/private/Memcache/APCu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ public function get($key) {
}

public function set($key, $value, $ttl = 0) {
if ($ttl === 0) {
$ttl = self::DEFAULT_TTL;
}
return apcu_store($this->getPrefix() . $key, $value, $ttl);
}

Expand Down Expand Up @@ -56,6 +59,9 @@ public function clear($prefix = '') {
* @return bool
*/
public function add($key, $value, $ttl = 0) {
if ($ttl === 0) {
$ttl = self::DEFAULT_TTL;
}
return apcu_add($this->getPrefix() . $key, $value, $ttl);
}

Expand Down
5 changes: 5 additions & 0 deletions lib/public/ICache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@
* @since 6.0.0
*/
interface ICache {
/**
* @since 30.0.0
*/
public const DEFAULT_TTL = 24 * 60 * 60;

/**
* Get a value from the user cache
* @param string $key
Expand Down