[stable27] fix(Session): avoid race conditions on clustered setups #46435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
bug
3. to review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $this->tokenProvider->invalidateToken($sessionId); | ||
| $this->tokenProvider->generateToken($sessionId, $uid, $loginName, $pwd, $name, IToken::TEMPORARY_TOKEN, $remember); | ||
| $this->atomic(function () use ($sessionId, $uid, $loginName, $pwd, $name, $remember) { | ||
| $this->tokenProvider->invalidateToken($sessionId); |
Check failure
Code scanning / Psalm
UndefinedThisPropertyFetch
- re-stablishes old behaviour with cache to return null instead of throwing an InvalidTokenException when the token is cached as non-existing - token invalidation and re-generation are bundled in a DB transaction now Signed-off-by: Arthur Schiwon <[email protected]>
prefer to keep this check as PublicEmitter should be dropped sooner or later Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
backport/46398/stable27
branch
from
fbb5339 to
e39be84
Compare
blizzz
requested review from
a team,
Altahrim,
sorbaugh and
yemkareems
and removed request for
a team
Altahrim
approved these changes
Jul 11, 2024
blizzz
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #46398
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.