Skip to content

[stable29] fix(appstore): Return an empty array in case of fail #46578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Jul 27, 2024
Merged

[stable29] fix(appstore): Return an empty array in case of fail #46578

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
837e006
fix(appstore): Return an empty array in case of fail
solracsf Jul 16, 2024
5a29cc5
chore: add warning in case of failure
solracsf Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(appstore): Return an empty array in case of fail 
Signed-off-by: Git'Fellow <[email protected]>
  • Loading branch information
@solracsf @AndyScherzinger
solracsf authored and AndyScherzinger committed Jul 25, 2024
commit 837e006e7f743567c4dc573316d210fcb35cdb5e
3 changes: 3 additions & 0 deletions lib/private/App/AppStore/Fetcher/AppFetcher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,9 @@ public function get($allowUnstable = false) {
$allowPreReleases = $allowUnstable || $this->getChannel() === 'beta' || $this->getChannel() === 'daily' || $this->getChannel() === 'git';

$apps = parent::get($allowPreReleases);
if (empty($apps)) {
return [];
}
$allowList = $this->config->getSystemValue('appsallowlist');

// If the admin specified a allow list, filter apps from the appstore
Expand Down