fix(caldav): decode values before returning #46594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SebastianKrupinski <[email protected]>
SebastianKrupinski
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
miaulalala
requested changes
Jul 18, 2024
st3iny
approved these changes
Jul 18, 2024
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
Tested and works. I reproduced the initial issue before applying the PR and it is fixed now.
Member
|
For reference, this is how the array looks before and after decoding:
|
miaulalala
approved these changes
Jul 18, 2024
Contributor
|
/backport to stable29 |
Contributor
|
/backport to stable28 |
This was referenced Jul 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper iTip message is now generated