Skip to content

[stable27] fix(files_sharing): also allow removing READ permissions on email shares #46600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 1 commit into from
Jul 18, 2024
Merged

[stable27] fix(files_sharing): also allow removing READ permissions on email shares #46600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(files_sharing): also allow removing READ permissions on email shares 
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
  • Loading branch information
@skjnldsv @nextcloud-command
skjnldsv authored and nextcloud-command committed Jul 18, 2024
commit eb3eec5a9d8918710465bb2c0dcede005c6e22a4
5 changes: 4 additions & 1 deletion apps/files_sharing/src/views/SharingDetailsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,10 @@ export default {
return (this.fileInfo.canDownload() || this.canDownload)
},
canRemoveReadPermission() {
return this.allowsFileDrop && this.share.type === this.SHARE_TYPES.SHARE_TYPE_LINK
return this.allowsFileDrop && (
this.share.type === this.SHARE_TYPES.SHARE_TYPE_LINK
|| this.share.type === this.SHARE_TYPES.SHARE_TYPE_EMAIL
)
},
// if newPassword exists, but is empty, it means
// the user deleted the original password
Expand Down
4 changes: 2 additions & 2 deletions dist/files_sharing-files_sharing_tab.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files_sharing-files_sharing_tab.js.map
View file
Open in desktop

Large diffs are not rendered by default.