fix(caldav): fixed initial sync and double processing #46623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianKrupinski
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
SebastianKrupinski
force-pushed
the
fix/issue-44127
branch
2 times, most recently
from
d86d377 to
bf6bb68
Compare
ChristophWurst
requested changes
Jul 19, 2024
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
- Always use prepared statements with parameters
- Add a test to
\OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest
SebastianKrupinski
force-pushed
the
fix/issue-44127
branch
3 times, most recently
from
250f3a6 to
e450139
Compare
st3iny
reviewed
Jul 29, 2024
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
This is also a (minor) performance optimization as we do $qb->func()->max('operation') instead of a busy loop now 👍
I'm gonna give this a test but looks good so far.
st3iny
reviewed
Jul 29, 2024
SebastianKrupinski
force-pushed
the
fix/issue-44127
branch
from
069959f to
c5796d3
Compare
st3iny
requested changes
Jul 30, 2024
miaulalala
approved these changes
Jul 30, 2024
st3iny
approved these changes
Jul 31, 2024
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
LGTM! Refactoring of the incremental sync case is a (minor) performance improvement. Additional unit tests are always welcome.
Signed-off-by: SebastianKrupinski <[email protected]>
SebastianKrupinski
force-pushed
the
fix/issue-44127
branch
from
0eb6cda to
a56d0db
Compare
ChristophWurst
approved these changes
Aug 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary