Skip to content

fix(caldav): test for null and blank value #46624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SebastianKrupinski merged 1 commit into from
Aug 8, 2024
Merged

fix(caldav): test for null and blank value #46624

SebastianKrupinski merged 1 commit into from
Aug 8, 2024

Conversation

@SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski commented Jul 19, 2024

Summary

  • Testing with empty will accommodate both null and empty string values

@SebastianKrupinski SebastianKrupinski self-assigned this Jul 19, 2024
@SebastianKrupinski SebastianKrupinski added the 3. to review Waiting for reviews label Jul 19, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 19, 2024
View reviewed changes
apps/dav/lib/CalDAV/Reminder/ReminderService.php
$calendarInfo = $this->caldavBackend->getCalendarById($calendarid);
$tzProp = '{urn:ietf:params:xml:ns:caldav}calendar-timezone';
if (!isset($calendarInfo[$tzProp])) {
if (empty($calendarInfo[$tzProp])) {

Check notice

Code scanning / Psalm

RiskyTruthyFalsyComparison

Operand of type null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead.
ChristophWurst
ChristophWurst reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test to \OCA\DAV\Tests\unit\CalDAV\Reminder\ReminderServiceTest

@susnux susnux added the bug label Jul 25, 2024
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 27, 2024
ChristophWurst
ChristophWurst approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the test 🙏

@SebastianKrupinski SebastianKrupinski merged commit e21fc6c into master Aug 8, 2024
@SebastianKrupinski SebastianKrupinski deleted the fix/issue-43923 branch August 8, 2024 11:55
@Altahrim Altahrim mentioned this pull request Aug 8, 2024
Merged
@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@miaulalala miaulalala miaulalala approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees

@SebastianKrupinski SebastianKrupinski

Labels

2. developing Work in progress bug

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

[Bug]: Error while running background job (End of document reached prematurely)

7 participants

@SebastianKrupinski @ChristophWurst @miaulalala @AndyScherzinger @susnux @skjnldsv