Avoid using partial file info as valid one #46672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
a team,
Altahrim,
icewind1991 and
yemkareems
and removed request for
a team
Altahrim
approved these changes
Jul 22, 2024
juliusknorr
force-pushed
the
fix/preview-invalid-id
branch
3 times, most recently
from
0125534 to
d86976c
Compare
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
fix/preview-invalid-id
branch
from
d86976c to
2b0bc8b
Compare
AndyScherzinger
approved these changes
Jul 25, 2024
This was referenced Jul 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This introduces a fix for object storage where partial file info could have lead to using 0 as a file id for partial files. In addition the second commit will make sure that instead of the partial one if we have (which is always the case with object storage as we create the file info before writing to storage).
Checklist