feat: add config flag to toggle persistent redis connections #46674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
requested review from
a team,
Altahrim,
ArtificialOwl and
yemkareems
and removed request for
a team
Altahrim
approved these changes
Jul 22, 2024
Collaborator
Altahrim
left a comment
Altahrim
left a comment
There was a problem hiding this comment.
Do you have examples of the issues?
sorbaugh
approved these changes
Jul 22, 2024
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persistent redis connections were introduced with #30959 but looks like they might cause issues in some load-balanced setups.