Skip to content

[stable28] fix(files): validate input when creating file/directory #46717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 4 commits into from
Jul 24, 2024
Merged

[stable28] fix(files): validate input when creating file/directory #46717

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f1d625
fix: FileInfo from `View` should have the correct name of a mountpoint
susnux Jul 22, 2024
b305be4
Merge pull request #46720 from nextcloud/backport/46694/stable28
susnux Jul 24, 2024
1c0a1cb
fix(files): validate input when creating file/directory
Antreesy Jul 22, 2024
7bf8dba
chore(assets): Recompile assets
nextcloud-command Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: FileInfo from View should have the correct name of a mountpoint 
If a mountpoint is returned from a `View` the name must match the view scoped name
and not the global name.
For example group folders have a name like `1` or `2` (the ID),
but the name of the FileInfo returned fro mthe View should be the mount point name,
like `First groupfolder` or similar.

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux @backportbot
susnux authored and backportbot[bot] committed Jul 24, 2024
commit 1f1d62521260b5d339bdff88889ee05484782262
4 changes: 4 additions & 0 deletions lib/private/Files/View.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1388,6 +1388,10 @@ public function getFileInfo($path, $includeMountPoints = true) {
if ($mount instanceof MoveableMount && $internalPath === '') {
$data['permissions'] |= \OCP\Constants::PERMISSION_DELETE;
}
if ($internalPath === '' && $data['name']) {
$data['name'] = basename($path);
}

$ownerId = $storage->getOwner($internalPath);
$owner = null;
if ($ownerId !== null && $ownerId !== false) {
Expand Down