Skip to content

[stable29] fix(files_sharing): open-in-files should open a folder and not the parent #46755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 4 commits into from
Aug 2, 2024
Merged

[stable29] fix(files_sharing): open-in-files should open a folder and not the parent #46755

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d2d98f
fix(files_sharing): `open-in-files` should open a folder and not the …
susnux Jul 19, 2024
62cf0a3
test: Add regression test for opening shared folders
susnux Jul 25, 2024
73b71fd
chore: Compile assets
susnux Jul 25, 2024
0523fad
fix(cypress): filesSharingUtils import
skjnldsv Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: Compile assets 
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
  • Loading branch information
@susnux @skjnldsv
susnux authored and skjnldsv committed Aug 2, 2024
commit 73b71fd8350aaba015706439d68a4ea73d32f751
12 changes: 10 additions & 2 deletions apps/files_sharing/src/actions/openInFilesAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,16 @@ export const action = new FileAction({

window.OCP.Files.Router.goToRoute(
null, // use default route
{ view: 'files', fileid: node.fileid },
{ dir: node.dirname, openfile: 'true' },
{
view: 'files',
fileid: String(node.fileid),
},
{
// If this node is a folder open the folder in files
dir: isFolder ? node.path : node.dirname,
// otherwise if this is a file, we should open it
openfile: isFolder ? undefined : 'true',
},
)
return null
},
Expand Down
Loading