fix(testing): Make Testing TextProcessing providers unicode safe #46779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
requested review from
bigcat88,
julien-nc,
juliusknorr and
kyteinsky
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kyteinsky
reviewed
Jul 26, 2024
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
fix/testing/textprocessing-unicode
branch
from
0c6fc86 to
b9187dc
Compare
kyteinsky
approved these changes
Jul 26, 2024
skjnldsv
approved these changes
Jul 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Fake TextProcessing providers implemented in the testing app would fail when used in the TaskProcessing API because they do not produce valid unicode. This PR fixes that.
Checklist