Skip to content

[stable29] style(settings): align icons at legacy help navigation #46787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Antreesy merged 1 commit into from
Jul 26, 2024
Merged

[stable29] style(settings): align icons at legacy help navigation #46787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
style(settings): align icons at legacy help navigation 
Signed-off-by: Maksim Sukharev <[email protected]>
  • Loading branch information
@Antreesy @backportbot
Antreesy authored and backportbot[bot] committed Jul 26, 2024
commit 92122d4d5953414564c68c7231703f60180649e3
10 changes: 9 additions & 1 deletion apps/settings/css/help.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,16 @@
overflow: hidden !important;
}

.help-list__link {
display: flex;
align-items: center;
height: var(--default-clickable-area);
margin: 0 8px;
background-position: left center;
}

.help-list__text {
margin-left: 24px;
margin-left: 20px;
}

.help-iframe {
Expand Down
8 changes: 4 additions & 4 deletions apps/settings/templates/help.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<div id="app-navigation" role="navigation" tabindex="0">
<ul>
<li>
<a class="icon-user <?php if ($_['mode'] === 'user') {
<a class="help-list__link icon-user <?php if ($_['mode'] === 'user') {
p('active');
} ?>" <?php if ($_['mode'] === 'user') {
print_unescaped('aria-current="page"');
Expand All @@ -18,7 +18,7 @@
</li>
<?php if ($_['admin']) { ?>
<li>
<a class="icon-user-admin <?php if ($_['mode'] === 'admin') {
<a class="help-list__link icon-user-admin <?php if ($_['mode'] === 'admin') {
p('active');
} ?>" <?php if ($_['mode'] === 'admin') {
print_unescaped('aria-current="page"');
Expand All @@ -32,14 +32,14 @@
<?php } ?>

<li>
<a href="https://docs.nextcloud.com" class="icon-category-office" target="_blank" rel="noreferrer noopener">
<a href="https://docs.nextcloud.com" class="help-list__link icon-category-office" target="_blank" rel="noreferrer noopener">
<span class="help-list__text">
<?php p($l->t('Documentation')); ?> ↗
</span>
</a>
</li>
<li>
<a href="https://help.nextcloud.com" class="icon-comment" target="_blank" rel="noreferrer noopener">
<a href="https://help.nextcloud.com" class="help-list__link icon-comment" target="_blank" rel="noreferrer noopener">
<span class="help-list__text">
<?php p($l->t('Forum')); ?> ↗
</span>
Expand Down