Skip to content

Fix status check and saving of external storages #46859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 11 commits into from
Sep 4, 2024
Merged

Fix status check and saving of external storages #46859

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4b26195
refactor: Store result in its own variable
danxuliu Jul 29, 2024
05bf573
fix: Recheck userglobal storages when loaded
danxuliu Jul 29, 2024
d0ba10d
fix: Remove status check when configuration was changed
danxuliu Jul 29, 2024
9eeb3cf
fix: Set status tooltip to status message when saving an storage
danxuliu Jul 29, 2024
ac1c8c4
fix: Set status tooltip to error message on failed actions
danxuliu Jul 29, 2024
2691983
fix: Restore default status tooltip when no status message is provided
danxuliu Jul 29, 2024
baaed7f
fix: Add missing translation for UI string
danxuliu Jul 29, 2024
8e5dba2
fix: Reset selected backend when adding a new storage
danxuliu Jul 29, 2024
8350aef
test: Add integration tests for saving external userglobal storages
danxuliu Jul 30, 2024
bd4de52
fix: Fix unmodified placeholder replacing the actual value when updating
danxuliu Jul 30, 2024
fa0862c
fix: Hide status tooltip in row to add a new mount point
danxuliu Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Reset selected backend when adding a new storage 
As a new storage is added by selecting a backend the selected backend
needs to be reset. Otherwise it is not possible to add another storage
with the same backend.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu @skjnldsv
danxuliu authored and skjnldsv committed Sep 4, 2024
commit 8e5dba2be0ad4726da4a3a2a89a21462bd3e84b1
2 changes: 2 additions & 0 deletions apps/files_external/js/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,6 +766,8 @@ MountConfigListView.prototype = _.extend({
storageConfig.backend = $target.val();
$tr.find('.mountPoint input').val('');

$tr.find('.selectBackend').prop('selectedIndex', 0)

var onCompletion = jQuery.Deferred();
$tr = this.newStorage(storageConfig, onCompletion);
$tr.find('.applicableToAllUsers').prop('checked', false).trigger('change');
Expand Down