Skip to content

fix(cloudfederationapi): Reduce deprecation spam when OCM is used #46885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nickvergessen wants to merge 1 commit into from
Closed

fix(cloudfederationapi): Reduce deprecation spam when OCM is used #46885

nickvergessen wants to merge 1 commit into from

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 30, 2024

Checklist

@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Jul 30, 2024
@nickvergessen nickvergessen added this to the Nextcloud 30 milestone Jul 30, 2024
@nickvergessen nickvergessen self-assigned this Jul 30, 2024
Antreesy
Antreesy approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blizzz blizzz mentioned this pull request Jul 30, 2024
Merged
@provokateurin
Copy link
Member

provokateurin commented Jul 30, 2024

Duplicate of #46744, can you just approve and merge that one as it already passed CI successfully?

@Antreesy
Copy link
Contributor

Antreesy commented Jul 30, 2024

Superseded

@Antreesy Antreesy closed this Jul 30, 2024
@provokateurin provokateurin deleted the bugfix/noid/reduce-attribute-spam-when-using-ocm branch July 30, 2024 15:57
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy approved these changes

@provokateurin provokateurin Awaiting requested review from provokateurin

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen @provokateurin @Antreesy @skjnldsv