Skip to content

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Jul 30, 2024

  • Resolves: #

Summary

Catch errors when inserting a version with same fileid and timestamp as the previous one, and retry with incremented timestamp.

Checklist

@come-nc come-nc added bug 3. to review Waiting for reviews labels Jul 30, 2024
@come-nc come-nc added this to the Nextcloud 30 milestone Jul 30, 2024
@come-nc come-nc requested a review from artonge July 30, 2024 15:10
@come-nc come-nc self-assigned this Jul 30, 2024
@solracsf
Copy link
Member

solracsf commented Jul 30, 2024

A similar logic could be applied to Groupfolders? I can observe these Constraints Violations using Groupfolders too.
https://github.com/nextcloud/groupfolders/blob/1933ff67ac47fabcd67b7f51e0318d3a11725089/lib/Versions/VersionsBackend.php#L110

@AndyScherzinger AndyScherzinger requested a review from sorbaugh July 31, 2024 08:21
@blizzz blizzz mentioned this pull request Aug 1, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv merged commit 1fa9d39 into master Aug 14, 2024
@skjnldsv skjnldsv deleted the fix/versions-catch-insertion-error branch August 14, 2024 08:32
@artonge
Copy link
Contributor

artonge commented Jun 2, 2025

@come-nc This solution seems to cause a new issue: #53151
Looking at it, I am also not sure about the rational. If a version is created, then why create an entity with a different timestamp?

@mpivchev
Copy link

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants