Skip to content

Conversation

@elzody
Copy link
Contributor

@elzody elzody commented Jul 30, 2024

Summary

There were some bugs with the template filler which caused a bad user experience. The following bugs are resolved with this pull request:

  • Closing the template filler without submitting anything caused an issue where you could not return to the template picker
  • The template filler appeared even if the template did not have any fields

Checklist

@elzody elzody added this to the Nextcloud 30 milestone Jul 30, 2024
@elzody elzody requested a review from juliusknorr July 30, 2024 19:37
@elzody elzody self-assigned this Jul 30, 2024
@elzody elzody requested a review from skjnldsv as a code owner July 30, 2024 19:37
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody elzody force-pushed the fix/template-filler branch from 835ab5f to e8c1e65 Compare July 30, 2024 20:06
@skjnldsv skjnldsv merged commit 45073f9 into master Jul 31, 2024
@skjnldsv skjnldsv deleted the fix/template-filler branch July 31, 2024 06:25
@skjnldsv
Copy link
Member

image

@elzody committing assets is not a fix :)

@elzody
Copy link
Contributor Author

elzody commented Jul 31, 2024

@skjnldsv what would be more appropriate?

@blizzz blizzz mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template form filling bugs

4 participants