Skip to content

[stable29] chore(ShareSettings): Proper wording for share autocompletion settings #46830 #46898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nfebe merged 2 commits into from
Jul 31, 2024
Merged

[stable29] chore(ShareSettings): Proper wording for share autocompletion settings #46830 #46898

nfebe merged 2 commits into from
Jul 31, 2024

Conversation

@nfebe
Copy link
Contributor

@nfebe nfebe commented Jul 30, 2024

Manual backport : #46830

@nfebe nfebe requested review from Pytal and susnux July 30, 2024 21:11
@nfebe nfebe enabled auto-merge July 30, 2024 21:11
@AndyScherzinger AndyScherzinger added this to the Nextcloud 29.0.5 milestone Jul 31, 2024
@nfebe @AndyScherzinger
chore(ShareSettings): Proper wording for share autocompletion settings
0faef87 
The existing is incorrect and can be misleading as seen in : #42501

Signed-off-by: fenn-cs <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the backport/46830/stable29 branch from 83566d1 to 0faef87 Compare July 31, 2024 08:37
@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Jul 31, 2024
@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jul 31, 2024

/compile /

@nextcloud-command
chore(assets): Recompile assets
6cc11e3 
Signed-off-by: nextcloud-command <[email protected]>
@nfebe nfebe merged commit e12217a into stable29 Jul 31, 2024
@nfebe nfebe deleted the backport/46830/stable29 branch July 31, 2024 09:09
@Altahrim Altahrim mentioned this pull request Aug 8, 2024
Merged
9 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees

No one assigned

Labels

3. to review Waiting for reviews feedback-requested

Projects

None yet

Milestone

Nextcloud 29.0.5

Development

Successfully merging this pull request may close these issues.

5 participants

@nfebe @AndyScherzinger @susnux @nextcloud-command