Skip to content

[stable28] chore(ShareSettings): Proper wording for share autocompletion settings #46899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nfebe merged 2 commits into from
Jul 31, 2024
Merged

[stable28] chore(ShareSettings): Proper wording for share autocompletion settings #46899

nfebe merged 2 commits into from
Jul 31, 2024

Conversation

@nfebe
Copy link
Contributor

@nfebe nfebe commented Jul 30, 2024

Manual backport : #46830

@nfebe
chore(ShareSettings): Proper wording for share autocompletion settings
56d4a1f 
The existing is incorrect and can be misleading as seen in : #42501

Signed-off-by: fenn-cs <[email protected]>
@nfebe nfebe added 3. to review Waiting for reviews feature: settings labels Jul 30, 2024
@nfebe nfebe requested review from Pytal, skjnldsv and susnux July 30, 2024 21:25
@nfebe nfebe enabled auto-merge July 30, 2024 21:25
@solracsf
Copy link
Member

solracsf commented Jul 31, 2024

/compile

@nextcloud-command
chore(assets): Recompile assets
2a0bef9 
Signed-off-by: nextcloud-command <[email protected]>
@nfebe nfebe merged commit 778c118 into stable28 Jul 31, 2024
@nfebe nfebe deleted the backport/46830/stable28 branch July 31, 2024 06:35
@Altahrim Altahrim mentioned this pull request Aug 8, 2024
Merged
3 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: settings feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nfebe @solracsf @susnux @skjnldsv @nextcloud-command