Skip to content

Fix: Update ConvertType.php to read correct DB params #46908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lwenderoth wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −8
Open

Fix: Update ConvertType.php to read correct DB params #46908

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
443cd29
Fix: Update ConvertType.php to read correct DB params, might fix #45257
lwenderoth Jul 31, 2024
76a3bb1
Update ConvertType.php again
lwenderoth Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update ConvertType.php again 
So embarrasing, sorry.. Creating new account, trying to get everything right - and commiting the wrong file.. Sorry!
This is the correction.

Signed-off-by: lwenderoth <[email protected]>
  • Loading branch information
@lwenderoth
lwenderoth authored Aug 1, 2024
commit 76a3bb1f51aa76afa1e61ae54bfa3c2199a0f950
2 changes: 1 addition & 1 deletion core/Command/Db/ConvertType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ protected function createSchema(Connection $fromDB, Connection $toDB, InputInter

protected function getToDBConnection(InputInterface $input, OutputInterface $output) {
$type = $input->getArgument('type');
$connectionParams = $this->connectionFactory->createDefaultConnectionParams($type);
$connectionParams = $this->connectionFactory->getDefaultConnectionParams($type);
$connectionParams = array_merge($connectionParams, [
'host' => $input->getArgument('hostname'),
'user' => $input->getArgument('username'),
Expand Down