Skip to content

fix(activity): regroup Files and split sharing activity #46942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Aug 1, 2024
Merged

fix(activity): regroup Files and split sharing activity #46942

skjnldsv merged 1 commit into from
Aug 1, 2024

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 1, 2024

Before After
2024-08-01_09-29 2024-08-01_09-28

@skjnldsv skjnldsv added 3. to review Waiting for reviews feature: activity and notification ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Aug 1, 2024
@skjnldsv skjnldsv requested review from a team and nickvergessen August 1, 2024 07:32
@skjnldsv skjnldsv self-assigned this Aug 1, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 1, 2024
Merged
AndyScherzinger
AndyScherzinger approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice polishing ✨

@skjnldsv skjnldsv enabled auto-merge August 1, 2024 07:48
@skjnldsv skjnldsv force-pushed the fix/activity-sections branch from 3938052 to 80231e6 Compare August 1, 2024 09:03
@skjnldsv skjnldsv merged commit b950047 into master Aug 1, 2024
@skjnldsv skjnldsv deleted the fix/activity-sections branch August 1, 2024 10:01
@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone Aug 1, 2024
@blizzz blizzz mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@yemkareems yemkareems yemkareems approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews feature: activity and notification ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv @nickvergessen @AndyScherzinger @yemkareems