turn LDAP's treat remnants as disabled feature config-independent #46992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
requested review from
a team,
artonge,
come-nc and
yemkareems
and removed request for
a team
blizzz
force-pushed
the
fix/noid/ldap-remnants-as-disabled-global
branch
from
65f3833 to
6a0351e
Compare
come-nc
requested changes
Aug 5, 2024
apps/user_ldap/lib/Migration/RearrangeMarkRemnantsAsDisabled.php
Outdated
Show resolved
Hide resolved
Merged
skjnldsv
added
2. developing
Merged
blizzz
force-pushed
the
fix/noid/ldap-remnants-as-disabled-global
branch
from
6a0351e to
6876d4f
Compare
blizzz
force-pushed
the
fix/noid/ldap-remnants-as-disabled-global
branch
4 times, most recently
from
a6ebee8 to
e06e762
Compare
blizzz
added
3. to review
come-nc
reviewed
Jun 19, 2025
blizzz
force-pushed
the
fix/noid/ldap-remnants-as-disabled-global
branch
from
e06e762 to
be1f72b
Compare
Signed-off-by: Arthur Schiwon <[email protected]>
- *ldap_mark_remnants_as_disabled were old values and removed now, after - combining their value and storing into current backend_mark_remnants_as_disabled Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
fix/noid/ldap-remnants-as-disabled-global
branch
from
be1f72b to
98a6a53
Compare
Member
Author
|
/compile amend / |
Signed-off-by: Arthur Schiwon <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/noid/ldap-remnants-as-disabled-global
branch
from
98a6a53 to
654f167
Compare
come-nc
reviewed
Jul 28, 2025
| } | ||
|
|
||
| protected function getGlobalAppValueAsBool(string $varName): bool { | ||
| static $appConfig; |
Contributor
There was a problem hiding this comment.
Same as the other one, static var is scary. Cache in a property or do not cache. (There is no way to reset the static var ever, while, the property can be reset by trashing the object and building a new one)
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
Contributor
|
@blizzz It would be nice to rebase this on the vue rewrite and remove the static vars. Then we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since former LDAP users cannot be bound to a server configuration anymore (or theoretically belong to more than one) this feature has to be config independent. This PR:
A backport to 28 will need further adjustments as
IAppConfigwas only introduced in 29.Checklist