fix: Do not log link reference exceptions as error #47048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyteinsky
approved these changes
Aug 5, 2024
AndyScherzinger
approved these changes
Aug 5, 2024
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
fix/log-link-reference-error
branch
from
063403a to
312314a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julius Härtl [email protected]
Summary
Errors that happen due to fetching an image from a remote URL are nothing critical and can regularly happen. The remote URl might have invalid image urls or be unreachable temporarily.
As for the other requests this changes the log level to debug instead.
Checklist