fix(admin_audit): Do not log errors for new files #47071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
fix/no-error-new-file-audit
branch
from
7f5da07 to
a56f5d4
Compare
juliusknorr
requested review from
a team,
artonge,
icewind1991 and
yemkareems
and removed request for
a team
AndyScherzinger
force-pushed
the
fix/no-error-new-file-audit
branch
from
a56f5d4 to
367c36a
Compare
AndyScherzinger
force-pushed
the
fix/no-error-new-file-audit
branch
from
367c36a to
0b399d2
Compare
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
fix/no-error-new-file-audit
branch
from
0b399d2 to
1c0f02e
Compare
AndyScherzinger
approved these changes
Aug 7, 2024
Merged
miaulalala
approved these changes
Aug 7, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid logging an error for cases when the audit log is triggered on a new file during the BeforeNodeReadEvent as in this case we get an NonExistingFile as the file has no file id yet
Sample error trace:
Checklist