Skip to content

fix(files): file name and header sort buttons alignments #47106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 1 commit into from
Aug 7, 2024
Merged

fix(files): file name and header sort buttons alignments #47106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/files/src/components/FilesListTableHeaderButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export default defineComponent({
<style scoped lang="scss">
.files-list__column-sort-button {
// Compensate for cells margin
margin: 0 calc(var(--cell-margin) * -1);
margin: 0 calc(var(--button-padding, var(--cell-margin)) * -1);
min-width: calc(100% - 3 * var(--cell-margin))!important;

&-text {
Expand Down
3 changes: 2 additions & 1 deletion apps/files/src/components/FilesListVirtual.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,6 +610,7 @@ export default defineComponent({
// Necessary for flex grow to work
min-width: 0;
margin: 0;
padding: 0;

// Already added to the inner text, see rule below
&:focus-visible {
Expand All @@ -630,7 +631,7 @@ export default defineComponent({
color: var(--color-main-text);
// Make some space for the outline
padding: var(--default-grid-baseline) calc(2 * var(--default-grid-baseline));
margin-left: -10px;
padding-left: 0;
// Align two name and ext
display: inline-flex;
}
Expand Down
4 changes: 2 additions & 2 deletions dist/files-main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files-main.js.map
View file
Open in desktop

Large diffs are not rendered by default.