Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Aug 8, 2024

Summary

This makes the focused app entry wider while shrinking its neighbors.

In this PR (currently) I use 3grid-baseline, but this is not enough for "Dashboard", do you think 4grid-baseline is ok? Meaning it would grow by 16px to 66px focused entry.

With this PR

Bildschirmaufnahme_20240808_160612.webm

With 4* grid baseline

Bildschirmaufnahme_20240808_161037.webm

Checklist

@susnux susnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Aug 8, 2024
@susnux susnux added this to the Nextcloud 30 milestone Aug 8, 2024
@susnux susnux marked this pull request as ready for review August 8, 2024 14:19
@AndyScherzinger
Copy link
Member

4grid baseline seems fine to me 👍

@susnux susnux mentioned this pull request Aug 8, 2024
@susnux susnux force-pushed the fix/app-menu-focus branch from faf8176 to e5bb27c Compare August 8, 2024 16:24
@susnux
Copy link
Contributor Author

susnux commented Aug 8, 2024

I changed the value to 4 * grid baseline now, so the second screen recording is the current version :)

@AndyScherzinger AndyScherzinger merged commit b30054a into master Aug 8, 2024
@AndyScherzinger AndyScherzinger deleted the fix/app-menu-focus branch August 8, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Bug]: App name does not show fully on hover/focus of specific app

4 participants