Skip to content

fix(files): Disable tags editing for shared files/folders with view only permission #47149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Aug 9, 2024
Merged

fix(files): Disable tags editing for shared files/folders with view only permission #47149

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81ee1ce
fix(files): Disable tags editing for shared files/folders with view o…
Koc Jul 21, 2024
de769f0
chore(assets): Recompile assets
nextcloud-command Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files): Disable tags editing for shared files/folders with view o… 
…nly permission

Signed-off-by: Konstantin Myakshin <[email protected]>
  • Loading branch information
@Koc @AndyScherzinger
Koc authored and AndyScherzinger committed Aug 9, 2024
commit 81ee1ce8fc75354a73b534ba43968ec8a296af87
1 change: 1 addition & 0 deletions apps/files/src/services/FileInfo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export default async function(url) {
// TODO remove when no more legacy backbone is used
fileInfo.get = (key) => fileInfo[key]
fileInfo.isDirectory = () => fileInfo.mimetype === 'httpd/unix-directory'
fileInfo.canEdit = () => Boolean(fileInfo.permissions & OC.PERMISSION_UPDATE)

return fileInfo
}
1 change: 1 addition & 0 deletions apps/files/src/views/Sidebar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
<div class="sidebar__description">
<SystemTags v-if="isSystemTagsEnabled && showTagsDefault"
v-show="showTags"
:disabled="!fileInfo?.canEdit()"
:file-id="fileInfo.id"
@has-tags="value => showTags = value" />
<LegacyView v-for="view in views"
Expand Down
5 changes: 5 additions & 0 deletions apps/systemtags/src/components/SystemTags.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
:options="sortedTags"
:value="selectedTags"
:create-option="createOption"
:disabled="disabled"
:taggable="true"
:passthru="true"
:fetch-tags="false"
Expand Down Expand Up @@ -65,6 +66,10 @@ export default Vue.extend({
type: Number,
required: true,
},
disabled: {
type: Boolean,
default: false,
},
},

data() {
Expand Down