Skip to content

perf(files): Prevent extraneous requests when tree children are loading #47157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pytal merged 2 commits into from
Aug 10, 2024
Merged

perf(files): Prevent extraneous requests when tree children are loading #47157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3ad8da
perf(files): Prevent extraneous requests when tree children are loading
Pytal Aug 9, 2024
d0186fe
chore: compile assets
Pytal Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions apps/files/src/views/folderTree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const isFolderTreeEnabled = loadState('files', 'config', { folder_tree: true }).
const Navigation = getNavigation()

const queue = new PQueue({ concurrency: 5, intervalCap: 5, interval: 200 })

const registerQueue = new PQueue({ concurrency: 5, intervalCap: 5, interval: 200 })

const registerTreeNodes = async (path: string = '/') => {
Expand All @@ -44,16 +45,12 @@ const registerTreeNodes = async (path: string = '/') => {
const getLoadChildViews = (node: TreeNode | Folder) => {
return async (view: View): Promise<void> => {
// @ts-expect-error Custom property on View instance
if (view.loaded) {
if (view.loading || view.loaded) {
return
}
// @ts-expect-error Custom property
view.loading = true
try {
await registerTreeNodes(node.path)
} catch (error) {
// Skip duplicate view registration errors
}
await registerTreeNodes(node.path)
// @ts-expect-error Custom property
view.loading = false
// @ts-expect-error Custom property
Expand Down
4 changes: 2 additions & 2 deletions dist/files-init.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files-init.js.map
View file
Open in desktop

Large diffs are not rendered by default.