Skip to content

Conversation

@GretaD
Copy link
Contributor

@GretaD GretaD commented Aug 14, 2024

backport of #45848

@GretaD
Copy link
Contributor Author

GretaD commented Aug 14, 2024

/compile amend /

@GretaD GretaD self-assigned this Aug 14, 2024
@GretaD GretaD added the bug label Aug 14, 2024
@GretaD GretaD marked this pull request as ready for review August 14, 2024 11:43
@GretaD GretaD added this to the Nextcloud 28.0.9 milestone Aug 14, 2024
@nextcloud-command nextcloud-command force-pushed the backportof/45848/stable28_ branch from 24087de to 0f7bc7c Compare August 14, 2024 12:05
@GretaD
Copy link
Contributor Author

GretaD commented Aug 19, 2024

/compile amend /

@nextcloud-command nextcloud-command force-pushed the backportof/45848/stable28_ branch from 0f7bc7c to 10b81ed Compare August 19, 2024 16:26

Check warning

Code scanning / CodeQL

Prototype-polluting function

Properties are copied from [e](1) to [t](2) without guarding against prototype pollution.
@GretaD
Copy link
Contributor Author

GretaD commented Aug 19, 2024

/compile amend /

@nextcloud-command nextcloud-command force-pushed the backportof/45848/stable28_ branch from 10b81ed to df2dd27 Compare August 19, 2024 17:35
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts

@GretaD GretaD force-pushed the backportof/45848/stable28_ branch from df2dd27 to 882ef07 Compare August 20, 2024 09:54
@skjnldsv skjnldsv mentioned this pull request Aug 20, 2024
12 tasks
@GretaD GretaD force-pushed the backportof/45848/stable28_ branch from 882ef07 to 5a1d356 Compare August 21, 2024 07:16
@skjnldsv skjnldsv changed the title Stable28: fix comment deletion [stable28] fix comment deletion Aug 21, 2024
@skjnldsv skjnldsv changed the title [stable28] fix comment deletion [stable28] Fix/comment deleting with activities installed Aug 21, 2024
@GretaD GretaD force-pushed the backportof/45848/stable28_ branch from 5a1d356 to 72c439b Compare August 21, 2024 09:02
@GretaD
Copy link
Contributor Author

GretaD commented Aug 21, 2024

/compile amend /

@GretaD GretaD force-pushed the backportof/45848/stable28_ branch from 72c439b to 1571b44 Compare August 21, 2024 13:41
@nextcloud-command nextcloud-command force-pushed the backportof/45848/stable28_ branch from 1571b44 to 7b659b0 Compare August 21, 2024 14:23
Signed-off-by: greta <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@GretaD GretaD force-pushed the backportof/45848/stable28_ branch from 7b659b0 to 4b0dc13 Compare August 22, 2024 08:16
@skjnldsv skjnldsv merged commit a0fbc5b into stable28 Aug 22, 2024
@skjnldsv skjnldsv deleted the backportof/45848/stable28_ branch August 22, 2024 10:52
@skjnldsv skjnldsv added the 4. to release Ready to be released and/or waiting for tests to finish label Aug 22, 2024
@blizzz blizzz mentioned this pull request Sep 4, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants