Skip to content

[stable28] fix(sharing): Pin @nextcloud/dialogs to a version that doesn't use Nextcloud 29 APIs #47271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 2 commits into from
Aug 23, 2024
Merged

[stable28] fix(sharing): Pin @nextcloud/dialogs to a version that doesn't use Nextcloud 29 APIs #47271

susnux merged 2 commits into from
Aug 23, 2024

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 16, 2024

Summary

  1. Create a folder with subfolder
  2. Create a public link
  3. Open public link in private Tab
  4. Upload a file
  5. Use the checkbox and the … Action
  6. Try to move to the subfolder
Before After
grafik grafik
grafik grafik

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 28.0.10 milestone Aug 16, 2024
@nickvergessen nickvergessen self-assigned this Aug 16, 2024
This was referenced Aug 16, 2024
Closed
Closed
ShGKme
ShGKme approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot find the corresponding PR, but I remember that bump fixed 3 other issues.

@nickvergessen
Copy link
Member Author

nickvergessen commented Aug 16, 2024

@susnux
Copy link
Contributor

susnux commented Aug 16, 2024

I created the PRs for branching v6.0.0 on the dialogs library and reverted that problematic patch, please review.
After that we can update stable28 to v5.3.6 and stable29 / stable30 / master to v6.0.0

susnux
susnux reviewed Aug 16, 2024
View reviewed changes
@nickvergessen nickvergessen force-pushed the bugfix/noid/fix-moving-files-in-public-shares branch from 2be0fde to c2c04b5 Compare August 19, 2024 07:42
@susnux susnux linked an issue Aug 19, 2024 that may be closed by this pull request
[Bug]: Move folders/files to public link share: No user ID found #45888
Closed
8 tasks
@susnux susnux force-pushed the bugfix/noid/fix-moving-files-in-public-shares branch from c2c04b5 to 9178455 Compare August 21, 2024 02:19
@susnux
Copy link
Contributor

susnux commented Aug 21, 2024

/compile

@susnux susnux enabled auto-merge August 21, 2024 02:19
@skjnldsv skjnldsv force-pushed the bugfix/noid/fix-moving-files-in-public-shares branch from d50a525 to fa21849 Compare August 21, 2024 07:53
@skjnldsv
Copy link
Member

skjnldsv commented Aug 21, 2024

files_copy-move.cy.ts doesnt't look so good 😕
Will restart

@nickvergessen
Copy link
Member Author

nickvergessen commented Aug 21, 2024

It had failed before your rebase and I had restarted it.
So might be related

@susnux
Copy link
Contributor

susnux commented Aug 21, 2024

It is related. This is a bug that was fixed but now back with the revert.

@susnux
Copy link
Contributor

susnux commented Aug 21, 2024

Fix: nextcloud-libraries/nextcloud-dialogs#1428

@nickvergessen
fix(sharing): Pin @nextcloud/dialogs to a version that doesn't use …
6dbe4e7 
…Nextcloud 29 APIs

[skip-ci]

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the bugfix/noid/fix-moving-files-in-public-shares branch from fa21849 to 6dbe4e7 Compare August 23, 2024 09:34
@nickvergessen
Copy link
Member Author

nickvergessen commented Aug 23, 2024

/compile /

@nextcloud-command
chore(assets): Recompile assets
5e52bea 
Signed-off-by: nextcloud-command <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 23, 2024
View reviewed changes
dist/comments-comments-tab.js Outdated

Check warning

Code scanning / CodeQL

Prototype-polluting function

Properties are copied from [e](1) to [t](2) without guarding against prototype pollution.
@susnux susnux merged commit 5ca832e into stable28 Aug 23, 2024
@susnux susnux deleted the bugfix/noid/fix-moving-files-in-public-shares branch August 23, 2024 11:03
@blizzz blizzz mentioned this pull request Sep 4, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ShGKme ShGKme ShGKme approved these changes

@nfebe nfebe Awaiting requested review from nfebe

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews bug feature: sharing

Projects

None yet

Milestone

Nextcloud 28.0.10

Development

Successfully merging this pull request may close these issues.

[Bug]: Move folders/files to public link share: No user ID found

6 participants

@nickvergessen @susnux @skjnldsv @ShGKme @nextcloud-command