[occ:bg-job:worker] Add 'stop_after' option #47277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
approved these changes
Aug 16, 2024
bigcat88
approved these changes
Aug 16, 2024
Contributor
bigcat88
left a comment
bigcat88
left a comment
There was a problem hiding this comment.
I agree that this should be backported in Nextcloud 30
skjnldsv
approved these changes
Aug 16, 2024
Member
|
change commit to |
julien-nc
force-pushed
the
enh/noid/occ-bg-job-worker-max-time
branch
from
2733477 to
39eeb00
Compare
Member
Author
|
/backport to stable30 |
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/occ-bg-job-worker-max-time
branch
from
39eeb00 to
8638f3b
Compare
Member
|
Maybe something for later but wouldn't it be possible to detect if any app version changed and only exit in that case? Similar how we build the cache buster for frontend assets based on the server and all app versions? |
juliusknorr
approved these changes
Aug 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
stop_afteroption is set, the worker will stop itself after the time set with the option value.As the worker does not update the loaded code (after an app upgrade for example) and the app setting values, we will recommend to regularly restart it. This option makes it possible to stop the worker after some time while it is not running a job.
IMO this should be backported to 30 as the worker is less useful without this option.