Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Aug 16, 2024

Backport of #46881

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug 3. to review Waiting for reviews high labels Aug 16, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.9 milestone Aug 16, 2024
instead of always picking the first one, try to find one that won't blow up

Signed-off-by: Robin Appelman <[email protected]>
@icewind1991 icewind1991 force-pushed the backport/46881/stable28 branch from 152907e to 0571aa1 Compare August 16, 2024 14:37
@icewind1991 icewind1991 marked this pull request as ready for review August 16, 2024 14:37
$this->cache = null;
break;
}
if (!$this->nonMaskedStorage) {

Check notice

Code scanning / Psalm

DocblockTypeContradiction

Operand of type false is always falsy
$this->cache = null;
break;
}
if (!$this->nonMaskedStorage) {

Check notice

Code scanning / Psalm

DocblockTypeContradiction

Docblock-defined type OCP\Files\Storage\IStorage for $this->nonMaskedStorage is never falsy
@sorbaugh sorbaugh merged commit 9f1c6d7 into stable28 Aug 19, 2024
@sorbaugh sorbaugh deleted the backport/46881/stable28 branch August 19, 2024 16:27
@skjnldsv skjnldsv mentioned this pull request Aug 20, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants