Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Aug 19, 2024

@backportbot backportbot bot requested review from come-nc, skjnldsv and sorbaugh August 19, 2024 13:13
@backportbot backportbot bot added the 3. to review Waiting for reviews label Aug 19, 2024
@come-nc come-nc self-assigned this Aug 19, 2024
@come-nc come-nc force-pushed the backport/47227/stable27 branch from 3d54d9c to e82ccee Compare August 19, 2024 14:03
@come-nc come-nc changed the title [stable27] [stable28] Apply group limit on remove from group [stable27] Apply group limit on remove from group Aug 19, 2024
@come-nc come-nc marked this pull request as ready for review August 19, 2024 14:06
@come-nc
Copy link
Contributor

come-nc commented Aug 20, 2024

So, bad news here, stable27 is not compatible with the cypress tests in there.
So the tests should be removed and this should be tested by hand to make sure it’s fixed in this PR on 27.

@come-nc come-nc force-pushed the backport/47227/stable27 branch from e82ccee to bc4802f Compare August 22, 2024 13:08
@come-nc
Copy link
Contributor

come-nc commented Aug 22, 2024

So, bad news here, stable27 is not compatible with the cypress tests in there. So the tests should be removed and this should be tested by hand to make sure it’s fixed in this PR on 27.

Tested, it works, and removed incompatible test from PR.
Good to merge.

@come-nc
Copy link
Contributor

come-nc commented Aug 22, 2024

/backport to stable26

@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 27, 2024
@come-nc come-nc force-pushed the backport/47227/stable27 branch from bc4802f to 850a0b3 Compare August 27, 2024 09:02
@AndyScherzinger AndyScherzinger merged commit 0e08a64 into stable27 Aug 27, 2024
@AndyScherzinger AndyScherzinger deleted the backport/47227/stable27 branch August 27, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants