Skip to content

Use logical positioning instead of physical for bidirectional text support #47343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 7 commits into from
Aug 29, 2024
Merged

Use logical positioning instead of physical for bidirectional text support #47343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
723780d
feat: Add bidi support in core directory
ahangarha Dec 19, 2023
66fab3f
Fix: background position based on direction
ahangarha Dec 23, 2023
26f4b97
Fix: shorthand paddings and margins
ahangarha Dec 23, 2023
c5baf3d
Fix: float and clear
ahangarha Dec 23, 2023
7b048e0
fix: Adjust some minor styles issues
susnux Aug 20, 2024
aea0e8d
fix: Adjust more places for logical position
susnux Aug 20, 2024
faeb2f0
chore: Add stylelint rules to verify we only use logical properties
susnux Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/comments/src/components/Comment.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ $comment-padding: 10px;
}

&__actions {
margin-left: $comment-padding !important;
margin-inline-start: $comment-padding !important;
}

&__author {
Expand All @@ -328,8 +328,8 @@ $comment-padding: 10px;

&_loading,
&__timestamp {
margin-left: auto;
text-align: right;
margin-inline-start: auto;
text-align: end;
white-space: nowrap;
color: var(--color-text-maxcontrast);
}
Expand All @@ -346,7 +346,7 @@ $comment-padding: 10px;
&__submit {
position: absolute !important;
bottom: 5px;
right: 0;
inset-inline-end: 0;
}

&__message {
Expand Down
9 changes: 4 additions & 5 deletions apps/dashboard/src/DashboardApp.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,11 +569,10 @@ export default {
background-size: 32px;
width: 32px;
height: 32px;
margin-right: 16px;
background-position: center;
float: left;
margin-top: -6px;
margin-left: 6px;
margin-inline: 6px 16px;
}

img {
Expand Down Expand Up @@ -609,7 +608,7 @@ export default {
margin:auto;
background-position: 16px center;
padding: 12px 16px;
padding-left: 36px;
padding-inline-start: 36px;
border-radius: var(--border-radius-pill);
max-width: 200px;
opacity: 1;
Expand Down Expand Up @@ -661,7 +660,7 @@ export default {
background-color: var(--color-background-hover);
border: 2px solid var(--color-main-background);
border-radius: var(--border-radius-large);
text-align: left;
text-align: start;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
Expand Down Expand Up @@ -691,7 +690,7 @@ export default {

input[type='checkbox'].checkbox + label:before {
position: absolute;
right: 12px;
inset-inline-end: 12px;
top: 16px;
}

Expand Down
10 changes: 5 additions & 5 deletions apps/dav/css/schedule-response.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,13 @@ form #selectPartStatForm label {
}

form #selectPartStatForm label:first-of-type {
border-top-left-radius: 4px;
border-bottom-left-radius: 4px;
border-start-start-radius: 4px;
border-end-start-radius: 4px;
}

form #selectPartStatForm label:last-of-type {
border-top-right-radius: 4px;
border-bottom-right-radius: 4px;
border-start-end-radius: 4px;
border-end-end-radius: 4px;
}

form #selectPartStatForm label span {
Expand Down Expand Up @@ -79,4 +79,4 @@ form input[type="submit"] {
display: block;
margin: 0 auto;
padding: 11px 20px 9px
}
}
13 changes: 7 additions & 6 deletions apps/dav/src/components/AvailabilityForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,13 @@ export default {
width: 120px;
}
.time-zone {
padding: 32px 12px 12px 0;
display: flex;
flex-wrap: wrap;
padding-block: 32px 12px;
padding-inline: 0 12px;
display: flex;
flex-wrap: wrap;

&__heading {
margin-right: calc(var(--default-grid-baseline) * 2);
margin-inline-end: calc(var(--default-grid-baseline) * 2);
line-height: var(--default-clickable-area);
font-weight: bold;
}
Expand Down Expand Up @@ -201,12 +202,12 @@ export default {
}

.to-text {
padding-right: 12px;
padding-inline-end: 12px;
}

.empty-content {
color: var(--color-text-lighter);
margin-top: 4px;
margin-block-start: var(--default-grid-baseline);
align-self: center;
}
</style>
4 changes: 2 additions & 2 deletions apps/dav/src/views/CalDavSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,10 @@ export default {

<style scoped>
.indented {
padding-left: 28px;
padding-inline-start: 28px;
}
/** Use deep selector to affect v-html */
* >>> a {
* :deep(a) {
text-decoration: underline;
}
.settings-hint {
Expand Down
6 changes: 3 additions & 3 deletions apps/federatedfilesharing/src/components/PersonalSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export default {
return window.location.protocol + '//' + window.location.host + this.logoPath
},
backgroundStyle() {
return `padding:10px;background-color:${this.color};color:${this.textColor};border-radius:3px;padding-left:4px;`
return `padding:10px;background-color:${this.color};color:${this.textColor};border-radius:3px;padding-inline-start:4px;`
},
linkStyle() {
return `background-image:url(${this.logoPathAbsolute});width:50px;height:30px;position:relative;top:8px;background-size:contain;display:inline-block;background-repeat:no-repeat; background-position: center center;`
Expand Down Expand Up @@ -164,7 +164,7 @@ export default {
margin-top: 0.5rem;
button {
display: inline-flex;
margin-left: 0.5rem;
margin-inline-start: 0.5rem;
margin-top: 1rem;
}
&__website-button {
Expand All @@ -184,6 +184,6 @@ export default {
white-space: pre-wrap;
}
#cloudid {
margin-left: 0.25rem;
margin-inline-start: 0.25rem;
}
</style>
6 changes: 3 additions & 3 deletions apps/federation/css/settings-admin.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,22 @@
.removeTrustedServer {
display: none;
vertical-align:middle;
padding-left: 10px;
padding-inline-start: 10px;
}

#ocFederationAddServerButton {
cursor: pointer;
}

#listOfTrustedServers .status {
margin-right: 10px;
margin-inline-end: 10px;
}

#listOfTrustedServers .icon {
cursor: pointer;
display: inline-block;
vertical-align: middle;
margin-left: 10px;
margin-inline-start: 10px;
}

#ocFederationAddServer #serverUrl {
Expand Down
2 changes: 1 addition & 1 deletion apps/files/css/detailsView.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/files/css/detailsView.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 4 additions & 5 deletions apps/files/css/detailsView.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@
}

.app-sidebar .thumbnailContainer.large {
margin-left: -15px;
margin-right: -35px; /* 15 + 20 for the close button */
margin-inline: -15px -35px; /* 15 + 20 for the close button */
margin-top: -15px;
}

Expand Down Expand Up @@ -73,15 +72,15 @@
overflow-x: hidden;
padding-top: 14px;
font-size: 80%;
margin-left: 0;
margin-inline-start: 0;
}

.app-sidebar .thumbnail {
width: 100%;
min-height: 75px;
display: inline-block;
float: left;
margin-right: 10px;
margin-inline-end: 10px;
background-size: contain;
background-repeat: no-repeat;
}
Expand Down Expand Up @@ -126,7 +125,7 @@
.app-sidebar .close {
position: absolute;
top: 0;
right: 0;
inset-inline-end: 0;
opacity: .5;
z-index: 1;
width: 44px;
Expand Down
2 changes: 1 addition & 1 deletion apps/files/css/files.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/files/css/files.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading