Skip to content

fix: FilenameValidator::isForbidden should only check forbidden files #47372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 2 commits into from
Aug 21, 2024
Merged

fix: FilenameValidator::isForbidden should only check forbidden files #47372

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9cc7bc
fix: `FilenameValidator::isForbidden` should only check forbidden files
susnux Aug 12, 2024
9157378
docs: Add information how forbidden filenames are handled on existing…
susnux Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
docs: Add information how forbidden filenames are handled on existing… 
… files.

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Aug 21, 2024
commit 91573781dfdabdac55307004aa554f8ade003289
8 changes: 6 additions & 2 deletions config/config.sample.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2008,8 +2008,9 @@
'updatedirectory' => '',

/**
* Block a specific file or files and disallow the upload of files
* with this name. ``.htaccess`` is blocked by default.
* Block a specific file or files and disallow the upload of files with this name.
* This blocks any access to those files (read and write).
* ``.htaccess`` is blocked by default.
*
* WARNING: USE THIS ONLY IF YOU KNOW WHAT YOU ARE DOING.
*
Expand All @@ -2021,6 +2022,7 @@

/**
* Disallow the upload of files with specific basenames.
* Matching existing files can no longer be updated and in matching folders no files can be created anymore.
*
* The basename is the name of the file without the extension,
* e.g. for "archive.tar.gz" the basename would be "archive".
Expand All @@ -2034,6 +2036,7 @@
/**
* Block characters from being used in filenames. This is useful if you
* have a filesystem or OS which does not support certain characters like windows.
* Matching existing files can no longer be updated and in matching folders no files can be created anymore.
*
* The '/' and '\' characters are always forbidden, as well as all characters in the ASCII range [0-31].
*
Expand All @@ -2046,6 +2049,7 @@

/**
* Deny extensions from being used for filenames.
* Matching existing files can no longer be updated and in matching folders no files can be created anymore.
*
* The '.part' extension is always forbidden, as this is used internally by Nextcloud.
*
Expand Down