feat(files): Allow more than 50 favorite views #47400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
susnux
approved these changes
Aug 21, 2024
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Nice! Fix, cleanup and semi-feature 😄
skjnldsv
approved these changes
Aug 21, 2024
susnux
force-pushed
the
feat/load-more-than-50-faves
branch
2 times, most recently
from
4f911c4 to
c887c14
Compare
Contributor
|
/backport to stable30 |
susnux
force-pushed
the
feat/load-more-than-50-faves
branch
from
c887c14 to
36c6fc6
Compare
Pytal
force-pushed
the
feat/load-more-than-50-faves
branch
from
36c6fc6 to
7117356
Compare
jancborchardt
approved these changes
Aug 27, 2024
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
…retrieval Co-authored-by: Ferdinand Thiessen <[email protected]> Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
feat/load-more-than-50-faves
branch
from
7117356 to
a1f4396
Compare
Pytal
added
4. to release
Member
Author
|
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
2 tasks
Merged
Contributor
|
For 29: #53643 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Technically this is a feature but could also be considered a fix. Favorites were being loaded with a hardcoded limit
server/apps/files/lib/Activity/Helper.php
Line 17 in c3ad469
Checklist