Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Aug 23, 2024

Summary

The loading icon visually informs that the node is currently loading, but there is no non-visual information (accessible information).
So this icon is not just visually pleasing, so add the accessible name.

Checklist

@susnux susnux added this to the Nextcloud 31 milestone Aug 23, 2024
@susnux susnux requested a review from a team August 23, 2024 00:16
@susnux susnux requested a review from skjnldsv as a code owner August 23, 2024 00:16
@susnux susnux requested review from artonge, nfebe and sorbaugh and removed request for a team August 23, 2024 00:16
@susnux
Copy link
Contributor Author

susnux commented Aug 23, 2024

/backport to stable30

@susnux susnux requested a review from Pytal August 23, 2024 17:48
@susnux susnux force-pushed the fix/files-non-visual-loading-info branch from a7bff26 to cac6e9e Compare August 26, 2024 23:52
@susnux
Copy link
Contributor Author

susnux commented Aug 26, 2024

/compile

@susnux susnux enabled auto-merge August 27, 2024 00:07
@AndyScherzinger
Copy link
Member

Needs a rebase and conflicts resolved, else 👍

@susnux susnux force-pushed the fix/files-non-visual-loading-info branch from 5f86ee0 to 1ec4aea Compare August 31, 2024 15:49
The loading icon visually informs that the node is currently loading,
but there is no non-visual information (accessible information).

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/files-non-visual-loading-info branch from 1ec4aea to cf976b2 Compare August 31, 2024 16:39
@susnux
Copy link
Contributor Author

susnux commented Aug 31, 2024

/compile

susnux and others added 2 commits August 31, 2024 20:14
@susnux susnux force-pushed the fix/files-non-visual-loading-info branch from a640153 to e934080 Compare August 31, 2024 18:14
@susnux susnux merged commit 8dd1696 into master Aug 31, 2024
@susnux susnux deleted the fix/files-non-visual-loading-info branch August 31, 2024 18:29
@backportbot
Copy link

backportbot bot commented Aug 31, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/47443/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f01c8efa 9ee2d134 e934080c

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47443/stable30

Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..8dd1696
From https://github.com/nextcloud/server

  • [deleted] (none) -> origin/7935-download-files-via-post
  • [deleted] (none) -> origin/JonathanTreffler-stop-spamming-deprecations
  • [deleted] (none) -> origin/add-clear-add-to-user-status-public-api
  • [deleted] (none) -> origin/add-integration-tests-for-getting-folder-sizes
  • [deleted] (none) -> origin/add-vtimezone-data-when-creating-personal-calendar
  • [deleted] (none) -> origin/admin_audit/enh/move-to-event-listeners
  • [deleted] (none) -> origin/artonge/feat/download_providers
  • [deleted] (none) -> origin/bug/files-scroll
  • [deleted] (none) -> origin/bugfix/38171/revert-status-when-overwritten
  • [deleted] (none) -> origin/bugfix/avoid-extra-stream-copy
  • [deleted] (none) -> origin/bugfix/noid/unavailable-shares
  • [deleted] (none) -> origin/cache-mimtype-mapping
  • [deleted] (none) -> origin/chore/catch-missing-non-optional-controller-parameter
  • [deleted] (none) -> origin/chore/security/log-password-confirmation-user-backend
  • [deleted] (none) -> origin/dependabot/npm_and_yarn/core-js-3.38.1
  • [deleted] (none) -> origin/direct-access-shared-calendar
  • [deleted] (none) -> origin/email-template-html-fragment
  • [deleted] (none) -> origin/enh/a11y-util
  • [deleted] (none) -> origin/enh/noid/iconfig
  • [deleted] (none) -> origin/enh/noid/use-taskprocessing-in-old-managers
  • [deleted] (none) -> origin/enhancement/caldav-resources-sync-command
  • [deleted] (none) -> origin/enhancement/typed-db-entity
  • [deleted] (none) -> origin/external-list-for
  • [deleted] (none) -> origin/extract-caldav-sharing-plugin
  • [deleted] (none) -> origin/feat-add-iavaialble-in-maintenance-mode
  • [deleted] (none) -> origin/feat/mail-admin-vue
  • [deleted] (none) -> origin/file-cache-insertion-atomic
  • [deleted] (none) -> origin/fix/files-non-visual-loading-info
  • [deleted] (none) -> origin/fix/header-styles
  • [deleted] (none) -> origin/fix/noid/identity-proof-key-checksum
  • [deleted] (none) -> origin/fix/user-settings-admin
  • [deleted] (none) -> origin/home-storage-lazy-datadir
  • [deleted] (none) -> origin/introduce/orm
  • [deleted] (none) -> origin/locate-key-fix
  • [deleted] (none) -> origin/mountcache-lazy-user
  • [deleted] (none) -> origin/multi-object-store
  • [deleted] (none) -> origin/remove_depreated_files
  • [deleted] (none) -> origin/setupmanager-lazy-user
  • [deleted] (none) -> origin/share-null-source
  • [deleted] (none) -> origin/storage-cache-init-in-transaction
  • [deleted] (none) -> origin/trashbin-skip-logging
  • [deleted] (none) -> origin/upload-chunk-locking
  • [deleted] (none) -> origin/use_HSTS
  • [deleted] (none) -> origin/user-files-debug-info
  • [deleted] (none) -> origin/work/sharing_trash
    error: Your local changes to the following files would be overwritten by merge:
    dist/4254-4254.js.map.license
    dist/4696-4696.js.map.license
    dist/5643-5643.js.map.license
    Please commit your changes or stash them before you merge.
    Aborting

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants