-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(files): Node loading information should be accessible #47443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable30 |
skjnldsv
approved these changes
Aug 23, 2024
artonge
approved these changes
Aug 26, 2024
a7bff26 to
cac6e9e
Compare
Contributor
Author
|
/compile |
Member
|
Needs a rebase and conflicts resolved, else 👍 |
5f86ee0 to
1ec4aea
Compare
The loading icon visually informs that the node is currently loading, but there is no non-visual information (accessible information). Signed-off-by: Ferdinand Thiessen <[email protected]>
1ec4aea to
cf976b2
Compare
Contributor
Author
|
/compile |
AndyScherzinger
approved these changes
Aug 31, 2024
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
a640153 to
e934080
Compare
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/47443/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f01c8efa 9ee2d134 e934080c
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47443/stable30Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..8dd1696
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The loading icon visually informs that the node is currently loading, but there is no non-visual information (accessible information).
So this icon is not just visually pleasing, so add the accessible name.
Checklist