Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Aug 24, 2024

Summary

On Firefox there is an old bug where when you move a dragged file outside the window the dragleave event is never emitted. So we just use a timeout to reset the drag over state.

Also a small change: Use the ID of the main container instead of relying on tag name and class. (The ID is guaranteed as other APIs rely on it, while the class is just used internally).

Screen recording

This is how the bug looks (before this PR):

Bildschirmaufnahme_20240824_120143.webm

Checklist

@susnux susnux modified the milestones: Nextcloud 30, Nextcloud 31 Aug 24, 2024
@susnux susnux marked this pull request as ready for review August 24, 2024 10:04
@susnux susnux requested a review from skjnldsv as a code owner August 24, 2024 10:04
@susnux susnux requested review from Pytal, artonge and nfebe August 24, 2024 10:04
@susnux
Copy link
Contributor Author

susnux commented Aug 24, 2024

Firefox bugs that cause this:

  1. https://bugzilla.mozilla.org/show_bug.cgi?id=1427644
  2. https://bugzilla.mozilla.org/show_bug.cgi?id=656164

And yes those are open since Firefox 4(!)

@susnux susnux added the design Design, UI, UX, etc. label Aug 24, 2024
@susnux
Copy link
Contributor Author

susnux commented Aug 24, 2024

/backport to stable30

@susnux
Copy link
Contributor Author

susnux commented Aug 24, 2024

/backport to stable29

@susnux susnux force-pushed the fix/files-drop-notice branch from 7ef9bb6 to f3a2d3b Compare August 26, 2024 11:47
@susnux susnux requested a review from artonge August 26, 2024 11:50
@susnux susnux force-pushed the fix/files-drop-notice branch from f3a2d3b to 98d5d86 Compare August 26, 2024 11:50
@susnux
Copy link
Contributor Author

susnux commented Aug 26, 2024

/compile

@susnux
Copy link
Contributor Author

susnux commented Aug 26, 2024

BTW not sure if this has side effects, but to prevent them if they exist I do not like
delete this.$route.query.XY but prefer creating a copy first so we do not trigger side effects until the $router.push.

@susnux susnux force-pushed the fix/files-drop-notice branch from 506deec to a86ce67 Compare August 26, 2024 14:42
@susnux
Copy link
Contributor Author

susnux commented Aug 26, 2024

/compile amend/

@susnux susnux requested a review from artonge August 26, 2024 14:42
susnux and others added 2 commits August 26, 2024 20:31
On firefox there is an old bug where when you move a dragged file outside
the window the `dragleave` event is never emitted.
So we just use a timeout to reset the drag over state.

Also a small change: Use the ID of the main container instead of relying on tag name and class.
(The ID is guranteed as other APIs rely on it, while the class is just used internally).

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv
Copy link
Member

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants