Skip to content

fix(files_external): Handling in SFTP UI for custom ports #47527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshtrichards merged 1 commit into from
Sep 12, 2024
Merged

fix(files_external): Handling in SFTP UI for custom ports #47527

joshtrichards merged 1 commit into from
Sep 12, 2024

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Aug 27, 2024 •
edited
Loading

Summary

Same as #47526 but for SFTP.

TODO

Checklist

@joshtrichards
Copy link
Member Author

joshtrichards commented Aug 27, 2024

/backport to stable30

@joshtrichards
Copy link
Member Author

joshtrichards commented Aug 27, 2024

/backport to stable29

joshtrichards added a commit to nextcloud/documentation that referenced this pull request Aug 27, 2024
@joshtrichards
docs: Update SFTP External Storage custom port instructions
ad95f07 
For nextcloud/server#47527

Signed-off-by: Josh <[email protected]>
@joshtrichards joshtrichards mentioned this pull request Aug 27, 2024
Merged
@solracsf solracsf added this to the Nextcloud 31 milestone Aug 27, 2024
@joshtrichards joshtrichards changed the title fix: custom port handling in UI for SFTP fix(files_external): Handling in SFTP UI for custom port handling Sep 7, 2024
@joshtrichards joshtrichards requested a review from susnux September 7, 2024 13:13
@joshtrichards joshtrichards changed the title fix(files_external): Handling in SFTP UI for custom port handling fix(files_external): Handling in SFTP UI for custom port Sep 7, 2024
@joshtrichards joshtrichards changed the title fix(files_external): Handling in SFTP UI for custom port fix(files_external): Handling in SFTP UI for custom ports Sep 7, 2024
@artonge
Copy link
Contributor

artonge commented Sep 9, 2024

Is this the only wiring needed for it to work? 😲

@joshtrichards
Copy link
Member Author

joshtrichards commented Sep 12, 2024

Is this the only wiring needed for it to work? 😲

Yes, seems so. Ends up in the correct place in the config when used.

@joshtrichards joshtrichards merged commit 56c744d into master Sep 12, 2024
@joshtrichards joshtrichards deleted the fix-sftp-custom-port-ui branch September 12, 2024 13:34
This was referenced Sep 12, 2024
Merged
Merged
backportbot bot pushed a commit to nextcloud/documentation that referenced this pull request Sep 14, 2024
@joshtrichards @backportbot
docs: Update SFTP External Storage custom port instructions
834f9e0 
For nextcloud/server#47527

Signed-off-by: Josh <[email protected]>
@joshtrichards joshtrichards mentioned this pull request Nov 15, 2024
Open
8 tasks
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim

@kesselb kesselb Awaiting requested review from kesselb

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: external storage

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

Setting custom port from GUI broken for FTP and SFTP External Storage with "other port" usage NEED TO PUT THAT IN DOCUMENT

5 participants

@joshtrichards @artonge @susnux @solracsf