fix(settings): Hide forbidden UI elements for group managers #47589

susnux · 2024-08-28T20:00:59Z

Resolves: Improve user management for group admins #24749
Resolves: [Bug]: accounts -> add new group visible for group admin, but not allowed #46831
Resolves: [Bug]: accounts -> recently active visible for group admins, but xhr request returns 403 #46778

Summary

The "recent" accounts API only works for admin and delegated admin -> hide for group managers
group managers can not create new groups -> Hide the UI to add a new group for them
Accounts created by group managers require one of the groups, which is managed by the group manager, assigned. So if the group manager only manages a single group, we should pre-select that group.

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

susnux · 2024-08-29T14:29:21Z

/backport to stable30

susnux · 2024-08-29T14:29:24Z

/backport to stable29

kesselb

Thank you

It fixes the issues I reported 🙏

kesselb · 2024-08-30T14:56:30Z

I would prefer a fresh issue to track that :)

There you go #47642

1. The "recent" accounts API only works for admin and delegated admin -> hide for line managers 2. Line managers can not create new groups -> Hide the UI to add a new group for them 3. Accounts created by line managers require one of the groups, which is managed by the line manager, assigned. So if the line manager only manageres a single group, we should preselect that group. Signed-off-by: Ferdinand Thiessen <[email protected]>

susnux · 2024-08-30T19:32:17Z

/compile

Signed-off-by: nextcloud-command <[email protected]>

backportbot · 2024-08-30T20:44:05Z

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/47589/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9a8b3de2 380b92c0

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47589/stable29

Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..558fbcd
From https://github.com/nextcloud/server

[deleted] (none) -> origin/7935-download-files-via-post
[deleted] (none) -> origin/JonathanTreffler-stop-spamming-deprecations
[deleted] (none) -> origin/add-clear-add-to-user-status-public-api
[deleted] (none) -> origin/add-integration-tests-for-getting-folder-sizes
[deleted] (none) -> origin/add-vtimezone-data-when-creating-personal-calendar
[deleted] (none) -> origin/admin_audit/enh/move-to-event-listeners
[deleted] (none) -> origin/artonge/feat/download_providers
[deleted] (none) -> origin/bug/files-scroll
[deleted] (none) -> origin/bugfix/38171/revert-status-when-overwritten
[deleted] (none) -> origin/bugfix/avoid-extra-stream-copy
[deleted] (none) -> origin/bugfix/noid/unavailable-shares
[deleted] (none) -> origin/cache-mimtype-mapping
[deleted] (none) -> origin/chore/catch-missing-non-optional-controller-parameter
[deleted] (none) -> origin/chore/security/log-password-confirmation-user-backend
[deleted] (none) -> origin/direct-access-shared-calendar
[deleted] (none) -> origin/email-template-html-fragment
[deleted] (none) -> origin/enh/a11y-util
[deleted] (none) -> origin/enh/noid/iconfig
[deleted] (none) -> origin/enh/noid/use-taskprocessing-in-old-managers
[deleted] (none) -> origin/enhancement/caldav-resources-sync-command
[deleted] (none) -> origin/enhancement/typed-db-entity
[deleted] (none) -> origin/external-list-for
[deleted] (none) -> origin/extract-caldav-sharing-plugin
[deleted] (none) -> origin/feat-add-iavaialble-in-maintenance-mode
[deleted] (none) -> origin/feat/mail-admin-vue
[deleted] (none) -> origin/file-cache-insertion-atomic
[deleted] (none) -> origin/fix/header-styles
[deleted] (none) -> origin/fix/noid/identity-proof-key-checksum
[deleted] (none) -> origin/fix/user-settings-admin
[deleted] (none) -> origin/home-storage-lazy-datadir
[deleted] (none) -> origin/introduce/orm
[deleted] (none) -> origin/locate-key-fix
[deleted] (none) -> origin/mountcache-lazy-user
[deleted] (none) -> origin/multi-object-store
[deleted] (none) -> origin/remove_depreated_files
[deleted] (none) -> origin/setupmanager-lazy-user
[deleted] (none) -> origin/share-null-source
[deleted] (none) -> origin/storage-cache-init-in-transaction
[deleted] (none) -> origin/trashbin-skip-logging
[deleted] (none) -> origin/upload-chunk-locking
[deleted] (none) -> origin/use_HSTS
[deleted] (none) -> origin/user-files-debug-info
[deleted] (none) -> origin/work/sharing_trash
error: Your local changes to the following files would be overwritten by merge:
dist/5643-5643.js.map.license
Please commit your changes or stash them before you merge.
Aborting

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

backportbot · 2024-08-30T20:44:44Z

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/47589/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9a8b3de2 380b92c0

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47589/stable30

Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..558fbcd
From https://github.com/nextcloud/server

[deleted] (none) -> origin/7935-download-files-via-post
[deleted] (none) -> origin/JonathanTreffler-stop-spamming-deprecations
[deleted] (none) -> origin/add-clear-add-to-user-status-public-api
[deleted] (none) -> origin/add-integration-tests-for-getting-folder-sizes
[deleted] (none) -> origin/add-vtimezone-data-when-creating-personal-calendar
[deleted] (none) -> origin/admin_audit/enh/move-to-event-listeners
[deleted] (none) -> origin/artonge/feat/download_providers
[deleted] (none) -> origin/bug/files-scroll
[deleted] (none) -> origin/bugfix/38171/revert-status-when-overwritten
[deleted] (none) -> origin/bugfix/avoid-extra-stream-copy
[deleted] (none) -> origin/bugfix/noid/unavailable-shares
[deleted] (none) -> origin/cache-mimtype-mapping
[deleted] (none) -> origin/chore/catch-missing-non-optional-controller-parameter
[deleted] (none) -> origin/chore/security/log-password-confirmation-user-backend
[deleted] (none) -> origin/direct-access-shared-calendar
[deleted] (none) -> origin/email-template-html-fragment
[deleted] (none) -> origin/enh/a11y-util
[deleted] (none) -> origin/enh/noid/iconfig
[deleted] (none) -> origin/enh/noid/use-taskprocessing-in-old-managers
[deleted] (none) -> origin/enhancement/caldav-resources-sync-command
[deleted] (none) -> origin/enhancement/typed-db-entity
[deleted] (none) -> origin/external-list-for
[deleted] (none) -> origin/extract-caldav-sharing-plugin
[deleted] (none) -> origin/feat-add-iavaialble-in-maintenance-mode
[deleted] (none) -> origin/feat/mail-admin-vue
[deleted] (none) -> origin/file-cache-insertion-atomic
[deleted] (none) -> origin/fix/header-styles
[deleted] (none) -> origin/fix/noid/identity-proof-key-checksum
[deleted] (none) -> origin/fix/user-settings-admin
[deleted] (none) -> origin/home-storage-lazy-datadir
[deleted] (none) -> origin/introduce/orm
[deleted] (none) -> origin/locate-key-fix
[deleted] (none) -> origin/mountcache-lazy-user
[deleted] (none) -> origin/multi-object-store
[deleted] (none) -> origin/remove_depreated_files
[deleted] (none) -> origin/setupmanager-lazy-user
[deleted] (none) -> origin/share-null-source
[deleted] (none) -> origin/storage-cache-init-in-transaction
[deleted] (none) -> origin/trashbin-skip-logging
[deleted] (none) -> origin/upload-chunk-locking
[deleted] (none) -> origin/use_HSTS
[deleted] (none) -> origin/user-files-debug-info
[deleted] (none) -> origin/work/sharing_trash
error: Your local changes to the following files would be overwritten by merge:
dist/5643-5643.js.map.license
Please commit your changes or stash them before you merge.
Aborting

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

susnux added bug 3. to review Waiting for reviews feature: users and groups feature: settings labels Aug 28, 2024

susnux added this to the Nextcloud 31 milestone Aug 28, 2024

susnux requested review from a team, Pytal, artonge and sorbaugh and removed request for a team August 28, 2024 20:01

backportbot bot added the backport-request label Aug 29, 2024

This comment was marked as resolved.

Sign in to view

kesselb approved these changes Aug 30, 2024

View reviewed changes

This comment was marked as off-topic.

Sign in to view

This comment was marked as resolved.

Sign in to view

susnux changed the title ~~fix(settings): Hide forbidden UI elements for line managers~~ fix(settings): Hide forbidden UI elements for group managers Aug 30, 2024

Pytal approved these changes Aug 30, 2024

View reviewed changes

susnux force-pushed the fix/user-settings-admin branch from 8d53984 to 9a8b3de Compare August 30, 2024 19:32

chore(assets): Recompile assets

380b92c

Signed-off-by: nextcloud-command <[email protected]>

susnux merged commit 558fbcd into master Aug 30, 2024

susnux deleted the fix/user-settings-admin branch August 30, 2024 20:43

susnux mentioned this pull request Aug 30, 2024

[stable30] fix(settings): Hide forbidden UI elements for group managers #47651

Merged

4 tasks

skjnldsv mentioned this pull request Jan 7, 2025

31.0.0 beta 1 #50066

Merged

susnux mentioned this pull request Jan 23, 2025

[Bug]: /ocs/v2.php/cloud/users/admin returns 998 when accessing "Users" page #49194

Closed

8 tasks

susnux removed the backport-request label Jun 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(settings): Hide forbidden UI elements for group managers #47589

fix(settings): Hide forbidden UI elements for group managers #47589

Uh oh!

susnux commented Aug 28, 2024 •

edited

Loading

Uh oh!

susnux commented Aug 29, 2024

Uh oh!

susnux commented Aug 29, 2024

Uh oh!

This comment was marked as resolved.

kesselb left a comment

Uh oh!

This comment was marked as off-topic.

This comment was marked as resolved.

This comment was marked as resolved.

kesselb commented Aug 30, 2024

Uh oh!

This comment was marked as resolved.

susnux commented Aug 30, 2024

Uh oh!

backportbot bot commented Aug 30, 2024

Uh oh!

backportbot bot commented Aug 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

fix(settings): Hide forbidden UI elements for group managers #47589

fix(settings): Hide forbidden UI elements for group managers #47589

Uh oh!

Conversation

susnux commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

susnux commented Aug 29, 2024

Uh oh!

susnux commented Aug 29, 2024

Uh oh!

This comment was marked as resolved.

kesselb left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

This comment was marked as resolved.

This comment was marked as resolved.

kesselb commented Aug 30, 2024

Uh oh!

This comment was marked as resolved.

susnux commented Aug 30, 2024

Uh oh!

backportbot bot commented Aug 30, 2024

Uh oh!

backportbot bot commented Aug 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

susnux commented Aug 28, 2024 •

edited

Loading