Skip to content

Conversation

@LukasReschke
Copy link
Member

Fixes #50

@LukasReschke LukasReschke added the 3. to review Waiting for reviews label Jul 20, 2016
@LukasReschke LukasReschke added this to the Nextcloud Next milestone Jul 20, 2016
@mention-bot
Copy link

@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @BernhardPosselt and @rullzer to be potential reviewers

@MorrisJobke
Copy link
Member

💥

PHP Fatal error:  Class 'OC\Appframework\Middleware\Security\Exceptions\StrictCookieMissingException' not found in /drone/src/github.com/nextcloud/server/lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php on line 141
[info] build failed (exit code 255)

@LukasReschke
Copy link
Member Author

PHP Fatal error: Class 'OC\Appframework\Middleware\Security\Exceptions\StrictCookieMissingException' not found in /drone/src/github.com/nextcloud/server/lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php on line 141
[info] build failed (exit code 255)

How much I love case-sensitive and case-insensitive OS…

@LukasReschke LukasReschke force-pushed the port-same-site-cookies branch from 779d742 to a299fa3 Compare July 20, 2016 16:38
@LukasReschke
Copy link
Member Author

Casing changed. Let's see if Drone is happy now… Tests are passing locally… (well they also passed before but 🙈 yay … computers 😉 )

@rullzer
Copy link
Member

rullzer commented Jul 20, 2016

👍

@LukasReschke
Copy link
Member Author

Since it's a simple port to master: Merge.

@LukasReschke LukasReschke merged commit 020a2a6 into master Jul 20, 2016
@LukasReschke LukasReschke deleted the port-same-site-cookies branch July 20, 2016 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants