-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix: Fix inaccessible content on public pages due to overlapping footer #47649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,19 +3,9 @@ | |
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
| #body-public { | ||
| --footer-height: calc(var(--default-line-height) + 2 * var(--default-grid-baseline));; | ||
|
|
||
| &:has(.footer__legal-links), | ||
| &:has(.footer__simple-sign-up) { | ||
| --footer-height: calc(2 * var(--default-line-height) + 3 * var(--default-grid-baseline));; | ||
| } | ||
|
|
||
| &:has(.footer__legal-links):has(.footer__simple-sign-up) { | ||
| --footer-height: calc(3 * var(--default-line-height) + 3 * var(--default-grid-baseline)); | ||
| } | ||
| --footer-height: calc(2lh + 2 * var(--default-grid-baseline)); // Set the initial value, will be updated programmatically to match the actual height | ||
|
|
||
| .header-end { | ||
|
|
||
| #header-primary-action a { | ||
| color: var(--color-primary-element-text); | ||
| } | ||
|
|
@@ -51,6 +41,7 @@ | |
|
|
||
| #content { | ||
| min-height: var(--body-height, calc(100% - var(--footer-height))); | ||
| padding-block-end: var(--footer-height); | ||
| } | ||
|
|
||
| #app-content-vue { | ||
|
Comment on lines
42
to
47
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (unrelated:) |
||
|
|
@@ -89,7 +80,6 @@ | |
| align-items: center; | ||
| justify-content: center; | ||
|
|
||
| height: var(--footer-height); | ||
| width: calc(100% - 2 * var(--body-container-margin)); | ||
| margin-inline: var(--body-container-margin); | ||
| padding-block: var(--default-grid-baseline); | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /** | ||
| * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| const body = document.body | ||
| const footer = document.querySelector('footer') | ||
| let prevHeight = footer?.offsetHeight | ||
|
|
||
| const onResize: ResizeObserverCallback = (entries) => { | ||
| for (const entry of entries) { | ||
| const height = entry.contentRect.height | ||
| if (height === prevHeight) { | ||
| return | ||
| } | ||
| prevHeight = height | ||
| body.style.setProperty('--footer-height', `${height}px`) | ||
| } | ||
| } | ||
|
|
||
| if (footer) { | ||
| new ResizeObserver(onResize) | ||
| .observe(footer, { | ||
| box: 'border-box', // <footer> is border-box | ||
| }) | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| SPDX-License-Identifier: AGPL-3.0-or-later | ||
| SPDX-FileCopyrightText: Nextcloud GmbH and Nextcloud contributors | ||
|
|
||
|
|
||
| This file is generated from multiple sources. Included packages: | ||
| - nextcloud | ||
| - version: 1.0.0 | ||
| - license: AGPL-3.0-or-later |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| core-public.js.license |
Uh oh!
There was an error while loading. Please reload this page.