fix(files): Correctly parse external shares for files UI #47665
Merged
+69
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
susnux
force-pushed
the
fix/files-remote-shares
branch
from
fdfe5aa to
6bf8c65
Compare
This comment was marked as resolved.
This comment was marked as resolved.
artonge
approved these changes
Sep 2, 2024
susnux
force-pushed
the
fix/files-remote-shares
branch
from
6bf8c65 to
02ed6a3
Compare
Contributor
Author
|
/compile |
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/files-remote-shares
branch
from
02ed6a3 to
8770e2b
Compare
Signed-off-by: nextcloud-command <[email protected]>
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/47665/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8770e2b2 541b2690
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47665/stable29Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..f9a71f3
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/47665/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8770e2b2 541b2690
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47665/stable30Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..f9a71f3
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Contributor
Author
|
/backport to stable30 |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/47665/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8770e2b2 541b2690
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47665/stable30Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..f9a71f3
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This was referenced Sep 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sadly the attributes of internal and external shares are named differently, this adds handling for all remote share attributes so we handle them similar to internal shares.
Checklist