Skip to content

[stable30] fix(files): Node loading information should be accessible #47666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 3 commits into from
Sep 1, 2024
Merged

[stable30] fix(files): Node loading information should be accessible #47666

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4b93d6
fix(files): Node loading information should be accessible
susnux Aug 22, 2024
49d2d96
test: Add Cypress test for renaming loading state
susnux Aug 23, 2024
1e6ce9a
chore(assets): Recompile assets
nextcloud-command Sep 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files): Node loading information should be accessible 
The loading icon visually informs that the node is currently loading,
but there is no non-visual information (accessible information).

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux @AndyScherzinger
susnux authored and AndyScherzinger committed Sep 1, 2024
commit b4b93d6bcd021aebc7be1186fe668c8786815fd6
7 changes: 6 additions & 1 deletion apps/files/src/components/FileEntry/FileEntryCheckbox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<template>
<td class="files-list__row-checkbox"
@keyup.esc.exact="resetSelection">
<NcLoadingIcon v-if="isLoading" />
<NcLoadingIcon v-if="isLoading" :name="loadingLabel" />
<NcCheckboxRadioSwitch v-else
:aria-label="ariaLabel"
:checked="isSelected"
Expand Down Expand Up @@ -83,6 +83,11 @@ export default defineComponent({
? t('files', 'Toggle selection for file "{displayName}"', { displayName: this.source.basename })
: t('files', 'Toggle selection for folder "{displayName}"', { displayName: this.source.basename })
},
loadingLabel() {
return this.isFile
? t('files', 'File is loading')
: t('files', 'Folder is loading')
},
},

methods: {
Expand Down