Skip to content

Check language files and database schema with app code checker #4767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 8 commits into from
May 16, 2017
Merged

Check language files and database schema with app code checker #4767

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
93fc7fc
Check the syntax of the language file
nickvergessen May 9, 2017
31bb65f
Check the name length of database items
nickvergessen May 9, 2017
8e757b3
Fix apps without translations
nickvergessen May 9, 2017
1951c88
We don't use the prefix on index names
nickvergessen May 10, 2017
3571355
Run the app checker on all apps
nickvergessen May 10, 2017
7ec5847
Fix return code handling
nickvergessen May 10, 2017
f920dfe
Skip the code checking for now
nickvergessen May 11, 2017
6dea5e6
Implement skip checkers and log the currently tested app
MorrisJobke May 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
We don't use the prefix on index names 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed May 16, 2017
commit 1951c88bdcc201078968613743229e4d97204855
10 changes: 4 additions & 6 deletions lib/private/App/CodeChecker/DatabaseSchemaChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,12 @@ public function analyse($appId) {

// Index names
foreach ($table->declaration->index as $index) {
if (strpos($index->name, '*dbprefix*') !== 0) {
$warnings[] = 'Database schema warning: name of index ' . $index->name . ' on table ' . $table->name . ' does not start with *dbprefix*';
}
$indexName = substr($index->name, strlen('*dbprefix*'));
if (strpos($indexName, '*dbprefix*') !== false) {
$warnings[] = 'Database schema warning: *dbprefix* should only appear once in name of index ' . $index->name . ' on table ' . $table->name;
$hasPrefix = strpos($index->name, '*dbprefix*');
if ($hasPrefix !== false && $hasPrefix !== 0) {
$warnings[] = 'Database schema warning: *dbprefix* should only appear at the beginning in name of index ' . $index->name . ' on table ' . $table->name;
}

$indexName = $hasPrefix === 0 ? substr($index->name, strlen('*dbprefix*')) : $index->name;
if (strlen($indexName) > 27) {
$errors[] = 'Database schema error: Name of index ' . $index->name . ' on table ' . $table->name . ' is too long (' . strlen($tableName) . '), max. 27 characters + *dbprefix* allowed';
}
Expand Down