fix(OCP): Fix Image interface #47676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
approved these changes
Sep 2, 2024
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
fix/ocp/image-interface
branch
from
e9f1da8 to
031166c
Compare
artonge
approved these changes
Sep 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using a private class in the public interface leads to no methods being resolved. Thus it needs to implement \OCP\IImage.
\OCP\IImage is also missing some methods that were relied on in OC_Image by other apps (e.g. Talk nextcloud/spreed#13197) and needed to be added.
Checklist