Skip to content

Conversation

@Ornanovitch
Copy link
Contributor

@Ornanovitch Ornanovitch commented Sep 2, 2024

This is my first manual backport, I couldn't make it with the official recommendations because I had an infinite list of conflicts (perhaps because I was previously working from a fork?)

Summary

Let the browser do its job regarding the appearance of the scrollbar

TODO

  • compile css

Error when I try npm run sass:

> [email protected] sass
> sass --style compressed --load-path core/css core/css/ $(for cssdir in $(find apps -mindepth 2 -maxdepth 2 -name "css"); do if ! $(git check-ignore -q $cssdir); then printf "$cssdir "; fi; done)

Error: Can't find stylesheet to import.
   ╷
15 │ @import '../../node_modules/@nextcloud/dialogs/dist/style';
   │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
  core/css/server.scss 15:9  root stylesheet

Checklist

@Ornanovitch Ornanovitch requested a review from susnux September 2, 2024 20:57
@susnux susnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Sep 2, 2024
@susnux susnux added this to the Nextcloud 30 milestone Sep 2, 2024
@susnux
Copy link
Contributor

susnux commented Sep 2, 2024

/compile

@AndyScherzinger
Copy link
Member

/compile

Signed-off-by: nextcloud-command <[email protected]>
@AndyScherzinger AndyScherzinger merged commit a484760 into stable30 Sep 2, 2024
@AndyScherzinger AndyScherzinger deleted the backport/47617/stable30 branch September 2, 2024 23:28
@blizzz blizzz mentioned this pull request Sep 4, 2024
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc. feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants