Skip to content

[stable29] [LinkReferenceProvider] Better size check #47696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 1 commit into from
Sep 4, 2024
Merged

[stable29] [LinkReferenceProvider] Better size check #47696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions lib/public/Collaboration/Reference/LinkReferenceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ private function fetchReference(Reference $reference): void {
}

$linkContentLength = $headResponse->getHeader('Content-Length');
if (is_numeric($linkContentLength) && (int) $linkContentLength > self::MAX_CONTENT_LENGTH) {
$this->logger->debug('Skip resolving links pointing to content length > 5 MiB');
if (is_numeric($linkContentLength) && (int)$linkContentLength > self::MAX_CONTENT_LENGTH) {
$this->logger->debug('[Head] Skip resolving links pointing to content length > 5 MiB');
return;
}

Expand All @@ -146,18 +146,28 @@ private function fetchReference(Reference $reference): void {
}

try {
$response = $client->get($reference->getId(), [ 'timeout' => 10 ]);
$response = $client->get($reference->getId(), [ 'timeout' => 10, 'stream' => true ]);
} catch (\Exception $e) {
$this->logger->debug('Failed to fetch link for obtaining open graph data', ['exception' => $e]);
return;
}

$responseBody = (string)$response->getBody();
$body = $response->getBody();
if (is_resource($body)) {
$responseContent = fread($body, self::MAX_CONTENT_LENGTH);
if (!feof($body)) {
$this->logger->debug('[Get] Skip resolving links pointing to content length > 5 MiB');
return;
}
} else {
$this->logger->error('[Get] Impossible to check content length');
return;
}

// OpenGraph handling
$consumer = new Consumer();
$consumer->useFallbackMode = true;
$object = $consumer->loadHtml($responseBody);
$object = $consumer->loadHtml($responseContent);

$reference->setUrl($reference->getId());

Expand Down