Skip to content

[stable29] Fix status check and saving of external storages #47734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danxuliu merged 11 commits into from
Sep 5, 2024
Merged

[stable29] Fix status check and saving of external storages #47734

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
80f038c
refactor: Store result in its own variable
danxuliu Jul 29, 2024
b71da3d
fix: Recheck userglobal storages when loaded
danxuliu Jul 29, 2024
8d3ff42
fix: Remove status check when configuration was changed
danxuliu Jul 29, 2024
caa7936
fix: Set status tooltip to status message when saving an storage
danxuliu Jul 29, 2024
981a20e
fix: Set status tooltip to error message on failed actions
danxuliu Jul 29, 2024
cdc64d1
fix: Restore default status tooltip when no status message is provided
danxuliu Jul 29, 2024
8a97029
fix: Add missing translation for UI string
danxuliu Jul 29, 2024
66c6890
fix: Reset selected backend when adding a new storage
danxuliu Jul 29, 2024
f34daed
test: Add integration tests for saving external userglobal storages
danxuliu Jul 30, 2024
5ed377e
fix: Fix unmodified placeholder replacing the actual value when updating
danxuliu Jul 30, 2024
8445050
fix: Hide status tooltip in row to add a new mount point
danxuliu Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Hide status tooltip in row to add a new mount point 
The row to add a new mount point is cloned when a new mountpoint is

added, so it is expected that it includes a status span. However, it

should not be displayed in that row, only in the cloned row when its

status is updated.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>

Signed-off-by: nextcloud-command <[email protected]>
  • Loading branch information
@danxuliu @AndyScherzinger
danxuliu authored and AndyScherzinger committed Sep 4, 2024
commit 844505023e7e0d40c2fff6831ed52acc2405b033
2 changes: 1 addition & 1 deletion apps/files_external/css/settings.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/files_external/css/settings.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/files_external/templates/settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ function writeParameterInput($parameter, $options, $classes = []) {
<?php endif; ?>
>
<td class="status">
<span data-placement="right" title="<?php p($l->t('Click to recheck the configuration')); ?>"></span>
<span data-placement="right" title="<?php p($l->t('Click to recheck the configuration')); ?>" style="display: none;"></span>
</td>
<td class="mountPoint"><input type="text" name="mountPoint" value=""
placeholder="<?php p($l->t('Folder name')); ?>">
Expand Down