Skip to content

[stable28] Fix status check and saving of external storages #47735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 12 commits into from
Sep 5, 2024
Merged

[stable28] Fix status check and saving of external storages #47735

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e43af1d
fix: Remove broken jQuery tooltip
danxuliu Aug 21, 2024
fc93517
refactor: Store result in its own variable
danxuliu Jul 29, 2024
dc18849
fix: Recheck userglobal storages when loaded
danxuliu Jul 29, 2024
9108d54
fix: Remove status check when configuration was changed
danxuliu Jul 29, 2024
35f16a3
fix: Set status tooltip to status message when saving an storage
danxuliu Jul 29, 2024
029626b
fix: Set status tooltip to error message on failed actions
danxuliu Jul 29, 2024
65885fe
fix: Restore default status tooltip when no status message is provided
danxuliu Jul 29, 2024
fa28a1d
fix: Add missing translation for UI string
danxuliu Jul 29, 2024
b72aebf
fix: Reset selected backend when adding a new storage
danxuliu Jul 29, 2024
59b62aa
test: Add integration tests for saving external userglobal storages
danxuliu Jul 30, 2024
0644361
fix: Fix unmodified placeholder replacing the actual value when updating
danxuliu Jul 30, 2024
b6d8e6b
fix: Hide status tooltip in row to add a new mount point
danxuliu Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Remove broken jQuery tooltip 
In Nextcloud 29 and later the tooltip usage threw an error that caused
the UI to be unusable, so it was removed. In Nextcloud 28 there is no
error, but using the jQuery tooltip call causes the tooltip to be
unreadable, so it was removed as well (which makes the native tooltip to
be shown instead).

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Sep 5, 2024
commit e43af1da715bc511d2513279c666a8a5c8475771
3 changes: 0 additions & 3 deletions apps/files_external/js/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1327,9 +1327,6 @@ MountConfigListView.prototype = _.extend({
}
if (typeof message === 'string') {
$statusSpan.attr('title', message);
$statusSpan.tooltip();
} else {
$statusSpan.tooltip('dispose');
}
},

Expand Down